This revision was automatically updated to reflect the committed changes.
Closed by commit R301:fb467669f8a3: KEmoticons: port plugins to JSON and add
support for loading with… (authored by dfaure).
REPOSITORY
R301 KEmoticons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8671?vs=219
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R301 KEmoticons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8671
To: dfaure, #frameworks, apol
Cc: apol
dfaure added a reviewer: apol.
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D8671
To: dfaure, #frameworks, apol
Cc: apol
dfaure added a comment.
ping?
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D8671
To: dfaure, #frameworks
Cc: apol
dfaure added a comment.
The KCM uses KServiceTypeTrader so we still need the desktop files.
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D8671
To: dfaure, #frameworks
Cc: apol
apol added a comment.
Other than that +1
INLINE COMMENTS
> CMakeLists.txt:19
> )
> -set_target_properties(emoticonstheme_adium PROPERTIES
> LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/emoticonsthemes")
> -install(
> -TARGETS emoticonstheme_adium
> -DESTINATION ${KDE_INSTAL
dfaure created this revision.
dfaure added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This makes it possible to run the autotests without installing kemoticons.
TEST PLAN
ctest; also playing a bit with `kcmshell5 emoticons`, but not full cover
