This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d328dd6ac725: Fix the result of KDesktopFile::sortOrder()
(authored by volkov).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8689?vs=22018=23548
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I don't really mind/care if it's fixed or not, if it's deprecated and unused
:-)
Want to submit a patch to deprecate it?
REPOSITORY
R237 KConfig
BRANCH
fix-sort-order
REVISION
volkov added a comment.
Well, at first I was planning to use this method in my project, but since
it's not used in KDE
and besides the SortOrder key is deprecated, I guess that
KDesktopFile::sortOrder() should be
marked as deprecated.
The question is whether to fix it first?
dfaure added a comment.
This looks correct, but did you find the KDE code that writes out this key?
A quick LXR search doesn't find anything relevant; do we use this feature at
all?
https://lxr.kde.org/search?_filestring=&_string=%22SortOrder%22&_casesensitive=1
REPOSITORY
R237
volkov added a reviewer: Frameworks.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8689
To: volkov, #frameworks
Cc: #frameworks
volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
KDesktopFile::sortOrder() returns the value of SortOrder key
as a string whithout parsing it as a list.
But according to Desktop Entry
