D8780: Try `llvm-config` to find `libclang`

turbov created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY The current way to search for `libclang` doesn't work for me (Gentoo with clang 4 and 5 installed). Instead of "

D8780: Try `llvm-config` to find `libclang`

shaheed added a comment. I'm afraid your's truly might take a bit of the blame. The basis of the logic was likely my original Python code, which did just enough to make Ubuntu work. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8780 To: turbov Cc: shah

D8780: Try `llvm-config` to find `libclang`

cgiboudeaux added inline comments. INLINE COMMENTS > FindPythonModuleGeneration.cmake:212 > +libclang_LIBRARY > +clang > +PATH ${LLVM_LIBDIR} NAMES clang clang-3.8 clang-3.9 and remove the lines 234-239 > FindPythonModuleGeneration.cmake:213 > +c

D8780: Try `llvm-config` to find `libclang`

turbov added inline comments. INLINE COMMENTS > cgiboudeaux wrote in FindPythonModuleGeneration.cmake:212 > NAMES clang clang-3.8 clang-3.9 > > and remove the lines 234-239 What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0??? I've just checked Ubuntu 14.04 (Clang 3.3 to 3.

D8780: Try `llvm-config` to find `libclang`

cgiboudeaux added inline comments. INLINE COMMENTS > turbov wrote in FindPythonModuleGeneration.cmake:212 > What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0??? > > I've just checked Ubuntu 14.04 (Clang 3.3 to 3.9 available) and 17.10 (up to > 5.0 available)... installing `li

D8780: Try `llvm-config` to find `libclang`

cgiboudeaux added inline comments. INLINE COMMENTS > turbov wrote in FindPythonModuleGeneration.cmake:213 > Why `HINTS` is "better"?? As for me this is not a "hint" -- at this point we > know exactly the correct libdir location... it is why I use `PATH`... https://cmake.org/cmake/help/v2.8.12/c

D8780: Try `llvm-config` to find `libclang`

shaheed added inline comments. INLINE COMMENTS > turbov wrote in FindPythonModuleGeneration.cmake:212 > What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0??? > > I've just checked Ubuntu 14.04 (Clang 3.3 to 3.9 available) and 17.10 (up to > 5.0 available)... installing `libcla

D8780: Try `llvm-config` to find `libclang`

shaheed added inline comments. INLINE COMMENTS > shaheed wrote in FindPythonModuleGeneration.cmake:212 > The original code had a minimum requirement of either 3.8 or 3.9 (I don't > recall exactly, but the code here implies 3.8 is the minimum). Newer versions > are fine. I remembered as soon as

D8780: Try `llvm-config` to find `libclang`

turbov added a comment. @cgiboudeaux, Yep, this review is the first in series about to clean up the code of `FindPythongModuleGeneration` and make it generic (not only for Ubuntu) and flexible. It is why I want to clean up it from "hard-coded" values like `3.8`/`3.9` and "brute force"

D8780: Try `llvm-config` to find `libclang`

shaheed added inline comments. INLINE COMMENTS > turbov wrote in FindPythonModuleGeneration.cmake:217 > As for me, I would remove whole this part of "brute forcing" available clang > version. I can't see how it could work w/o additional hints due a location > of `libclang` is not a standard di