cryptodude created this revision.
cryptodude added reviewers: dfaure, cfeck.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
In case the user starts the KPasswordDialog without the
KPasswordDialog::ShowUsernameLine,
t
ngraham added a comment.
Thanks for the patch! For UI changes, a before-and-after screenshot pair is
always nice. Also, have you tested that the default username-and-password combo
still works?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To: cryptod
cryptodude added a comment.
The changes are pretty simple, but testing it would require a lot of work as
it requires a full up-to-date KDE development system and I just don't have that
option.
So I can't give you a screenshot, as the "test plan" indicates, I visually
can't test it.
REP
dfaure added a comment.
The whole point of KDE Frameworks is that you don't need a "full up-to-date
KDE development system".
You can just install distro packages for Qt5 devel, and ECM, and then compile
and test kwidgetaddons from git without even having to install it, using a
unittest
cryptodude added a comment.
> so if something doesn't work, let me know ;-)
It took me quite some figuring out how this works. Thanks for stating it
really should work. The only way that I managed to get it to work is load the
project in QtCreator and select the 'debug' build there. I
cryptodude edited the test plan for this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To: cryptodude, dfaure, cfeck
Cc: ngraham, #frameworks
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks
ngraham added a comment.
@dfaure, does this look sane and sensible to you?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks
dfaure accepted this revision.
dfaure added a comment.
Sure.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0919a1b8ba52: Avoid inconsistent passworddialog (authored
by cryptodude, committed by ngraham).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8791?vs=22268&
10 matches
Mail list logo