This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c8bd7ad4b296: Created an auxiliary function
KFilePlacesModel::movePlace (authored by Renato Araujo Oliveira
Filho renato.ara...@kdab.com).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
renatoo updated this revision to Diff 23014.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22967=23014
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot added a dependent revision: D8366: Factoring out lists of url
data within KFilePlacesModelTest.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
renatoo updated this revision to Diff 22967.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22956=22967
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22956.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22818=22956
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
renatoo updated this revision to Diff 22818.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22809=22818
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22809.
renatoo marked 7 inline comments as done.
renatoo added a comment.
Fixed typos
Fixed code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22783=22809
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:1039
> +
> +//use a invalid start postion
> +QVERIFY(!m_places->movePlace(100, 20));
typo: position
>
renatoo updated this revision to Diff 22783.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22771=22783
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22771.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22762=22771
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22762.
renatoo marked an inline comment as done.
renatoo added a comment.
Implemented unit test
Fixed documentation
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22741=22762
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> kfileplacesmodel.h:80
> +/**
> + * @brief Move place at 'row' to a position before 'before'
> + * @since 5.41
this doesn't match the names of the parameters, and use @p rather than single
quotes.
REPOSITORY
R241 KIO
REVISION
renatoo planned changes to this revision.
renatoo added a comment.
Implement unit test
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added a reviewer: dfaure.
renatoo added a dependency: D8947: Expose KFilePlacesModel 'iconName' rule.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
with 'KFilePlacesModel::movePlace' the external APIs can easily move
items in the model without replicate the code.
TEST PLAN
Unit test
18 matches
Mail list logo
