D8964: Fix two bugs in KMessageWidget

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R236:e3368be660e3: Fix two bugs in KMessageWidget (authored by aacid). CHANGED PRIOR TO COMMIT

D8964: Fix two bugs in KMessageWidget

dhaumann accepted this revision. dhaumann added a comment. I just tested again with KWrite - I think it behaves good there. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8964 To: aacid, #frameworks, dhaumann Cc: kde-frameworks-devel, ngraham, dhaumann,

D8964: Fix two bugs in KMessageWidget

aacid added a comment. Restricted Application added a subscriber: kde-frameworks-devel. In D8964#175503 , @dhaumann wrote: > Please test the following: > > 1. load an existing file in kwrite: kwrite myFile > 2. touch it on console, e.g. echo

D8964: Fix two bugs in KMessageWidget

aacid planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8964 To: aacid, #frameworks Cc: ngraham, dhaumann, anthonyfieroni, #frameworks, michaelh

D8964: Fix two bugs in KMessageWidget

dhaumann added a comment. Please test the following: 1. load an existing file in kwrite: kwrite myFile 2. touch it on console, e.g. echo "asdf" >> myFile 3. Now a message widghet should appear on top of the view with a notification text. 4. This is animated. Is the final size

D8964: Fix two bugs in KMessageWidget

aacid added a comment. In https://phabricator.kde.org/D8964#173472, @dhaumann wrote: > In general this patch should be OK. > Could you try with Kate search warp behavior as well? KTextEditor relies on correct behaviors here heavily. What should i be looking at? that it appears

D8964: Fix two bugs in KMessageWidget

dhaumann added a comment. In general this patch should be OK. Could you try with Kate search warp behavior as well? KTextEditor relies on correct behaviors here heavily. INLINE COMMENTS > kmessagewidgetautotest.cpp:32-40 > +#define CHECK_FULLY_VISIBLE \ > +QVERIFY(w.isVisible()); \ >

D8964: Fix two bugs in KMessageWidget

anthonyfieroni added a comment. It looks good. INLINE COMMENTS > kmessagewidget.cpp:348 > +d->content->move(0, 0); > +setFixedHeight(d->content->height()); > +} Those it should be setFixedHeight(sizeHint().height()); REPOSITORY R236 KWidgetsAddons

D8964: Fix two bugs in KMessageWidget

aacid added a comment. Ping REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8964 To: aacid, #frameworks Cc: #frameworks

D8964: Fix two bugs in KMessageWidget

aacid updated this revision to Diff 22827. aacid added a comment. Small tweak to the test REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8964?vs=22825=22827 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8964 AFFECTED FILES

D8964: Fix two bugs in KMessageWidget

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Bug #1: If you call show() or setVisible() after animatedHide() nothing would happen This is because animatedHide() does

D8964: Fix two bugs in KMessageWidget

aacid added a reviewer: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8964 To: aacid, #frameworks Cc: #frameworks