anthonyfieroni abandoned this revision.
anthonyfieroni added a comment.
QAction dependency cannot be dropped.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9048
To: anthonyfieroni, davidedmundson, apol
Cc: graesslin, broulik, #frameworks
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in CMakeLists.txt:36
> A depend has widgets on a public interface, i guess
If KGlogalAccel needs Widgets, Widgets must stay.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9048
To:
anthonyfieroni added inline comments.
INLINE COMMENTS
> davidedmundson wrote in CMakeLists.txt:36
> lib still uses widgets, I doubt this will compile.
> If it does, it's because it's pulled in from something else.
>
> (in fact the runtime links against them too, but for a hidden window to
>
anthonyfieroni updated this revision to Diff 23132.
anthonyfieroni added a comment.
It compiles.
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9048?vs=23126=23132
REVISION DETAIL
https://phabricator.kde.org/D9048
AFFECTED FILES
CMakeLists.txt
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:36
> set(REQUIRED_QT_VERSION 5.7.0)
> -find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus Widgets)
>
broulik added a comment.
`QApplication` is for widgets, so you should keep it a `QGuiApplication` and
just remove the widgets dependency.
(The naming is confusing, indeed, it's QCoreApplication → QGuiApplication →
QApplication)
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9048
AFFECTED
