D9054: [CopyJob] Don't start all over after having removed a file

2017-11-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0bc40d7c8b71: [CopyJob] Don't start all over after having removed a file (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9054?vs=23143&id=23166 R

D9054: [CopyJob] Don't start all over after having removed a file

2017-11-29 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Heh this goes back to 2000 and the make_it_cool branch for kio, with non-STL iterator api, I think the return value was just missing from Qt back then ;) REPOSITORY R241 KIO REVISION DET

D9054: [CopyJob] Don't start all over after having removed a file

2017-11-29 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9054 To: broulik, #frameworks, dfaure

D9054: [CopyJob] Don't start all over after having removed a file

2017-11-29 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. TEST PLAN (I didn't git graft the original commit which might explain this?) But `shouldSkip()` doesn't change any state so I don't see how starting all over could be