D9070: KDE platform plugin: don't force default stylename on user-specified fonts

anthonyfieroni added a reviewer: dfaure. anthonyfieroni added a comment. I'm not sure it's Qt bug, it change behavior and now it doing in *right* way. So i'm patch to be merged +1. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. So this this actually resolve https://bugs.kde.org/show_bug.cgi?id=378523, or just lay the groundwork for resolving it? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmun

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > So this this actually resolve https://bugs.kde.org/show_bug.cgi?id=378523, or just lay the groundwork for resolving it? No, it's more a change similar to proposed fix for that bug (don't set a stylename in KFontRequester). This patch implements the principle

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolf

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. Does anyone have strong objections to landing this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: anthonyfieroni, ngraham, cfeck, fv

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

abetts added a comment. Is this change purely a conversation of what developers use in code to call up fonts in their applications? Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something like System Settings that wou

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > Is this change purely a conversation of what developers use in code to call up fonts in their applications? I think so. > Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something l

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. A diagonally related anecdote that shows this location is a more central point in the font selection process than I thought first: Applications like Qt's Assistant that call for Helvetica often end up using a font that looks pixelated - because it's actually an emb

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. Thanks for the info! So if/hen this goes in, what are the next steps? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: abetts, anthonyf

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > Thanks for the info! So if/hen this goes in, what are the next steps? I'd say - decide whether this is an issue you want to solve only for plasma environments, or for all platforms where KF5 applications are supported. - draw up the conditions under which

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. Thanks René. Regarding those questions, what would your preferences be? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: abetts, anthon

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

dfaure added a comment. I've been hitting a very similar bug where a Qt app was trying to use a bold font, and this had no effect when running in a plasma workspace, because of this code in kfontsettingsdata.cpp. Testcase (couldn't be simpler...) http://www.davidfaure.fr/2018/qlabel_inh

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > Unfortunately, this patch doesn't fix it. The text still isn't bold. No, this patch is written to be as transparent as possible. It won't impose a stylename, but will not remove it either. What happens when you remove the `,Regular`, i.e. [General]

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

dfaure added a comment. In https://phabricator.kde.org/D9070#197332, @rjvbb wrote: > What happens when you remove the `,Regular` That fixes the problem indeed. >> Workaround: enabling the line that calls QApplication::setDesktopSettingsAware(false). >> Proof that this c

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > In the code shown by this patch ;) Line 80. Right. Doh. The line that causes other side-effects when you comment it out :) > But the test you suggested that I do above is further proof anyhow. > > But even without setStyleName call (i.e.

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I think this patch makes sense, even though I'm sad that it doesn't actually fix the bug I was seeing (you call it broken config file, in that case that would mean that the code writing out

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. David, Could you please push it for me? I probably won't be able to do so for at least a week and it'd be a pity if the change just misses a release because of that. Thanks. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https:

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

bkchr added a comment. Hi, this patch is still no applied, would someone do it? :) Because it already missed 5.13. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfa

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

This revision was automatically updated to reflect the committed changes. Closed by commit R135:2e971be576d2: KDE platform plugin: don't force default stylename on user-specified fonts (authored by rjvbb, committed by fvogt). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES S

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

fvogt added a comment. In D9070#277428 , @bkchr wrote: > Hi, > this patch is still no applied, would someone do it? :) > Because it already missed 5.13. I pushed it now. REPOSITORY R135 Integration for Qt applications in Plasma RE

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

anthonyfieroni added reviewers: Frameworks, davidedmundson, graesslin. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > IMO that's a feature though and is the expected behaviour. For instance, if we change the default window title to be bold, users with "windowTitle=Comic Sans" will also have a bold title. So how would you "change the default window title to be bold" and more i

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

cfeck added a reviewer: cfeck. cfeck added a comment. The config would work with removed styleName() for the cases where the weight() and style() attributes are sufficient. The intention from Qt's side was to uniquely identify fonts that cannot be selected by those two attributes. Imagine a

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

fvogt added a comment. In https://phabricator.kde.org/D9070#173835, @rjvbb wrote: > > IMO that's a feature though and is the expected behaviour. For instance, if we change the default window title to be bold, users with "windowTitle=Comic Sans" will also have a bold title. > > So h

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

cfeck added a comment. The patch also addresses the bug only for default fonts, but not per-application fonts that write their settings to the appnamerc file. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #framewor

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > On the other hand, calling setBold(true) on a font called "HandwriteCursive" _should_ select "HandwriteBoldCursive", even if the styleName was intended to enforce a specific face. If Qt cannot fix this issue, then we have to clear the styleName() at least for those f

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. If you read https://bugreports.qt.io/browse/QTBUG-63792?focusedCommentId=381570 the take-home message seems to be that the platform theme plugin (and KDE in general) shouldn't be messing with setStyleName() at all UNLESS asking for a font with properties that cannot b