D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-04 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f75816a33a32: Initialize scale factor to the last scale factor set on any instance (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff,

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-03 Thread Eike Hein
hein reopened this revision. hein added a comment. Sorry, accidental push. I'll revert and reopen this. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart Cc: graesslin, plasma-devel, #frameworks,

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-03 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R242:15f470fafce3: Initialize scale factor to the last scale factor set on any instance (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-03 Thread Eike Hein
hein added a comment. So I worked out why this happens. We have API like this: SvgItem { svg: Svg { imagePath: "..." } } Without my patch, `Svg` is instanciated with a scale factor of 1.0 always. Then `setImagePath` is called on it first. Then `SvgItem::setSvg` is called

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-03 Thread Eike Hein
hein added a comment. In https://phabricator.kde.org/D9119#174887, @davidedmundson wrote: > how is this one method different from setSize setColorGroup setContainsMultipleImages setUseSystemColors etc.? Most of those don't show up at 2% during my plasmashell startup. The scale

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-03 Thread David Edmundson
davidedmundson added a comment. how is this one method different from setSize setColorGroup setContainsMultipleImages setUseSystemColors etc.? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-03 Thread Eike Hein
hein added a comment. Personally, I disagree it's hack. It's just defensively written: It makes sure users of the Svg API don't need to understand the order in which they need to call setScaleFactor and setImagePath for good performance. For something performance-critical I'd prefer not to

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-03 Thread Martin Flöser
graesslin added a comment. I agree with David that this is a hack. Also I think it will fail for multi screen with different dpi. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart Cc: graesslin,

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-02 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Use of static is a hack. If this fixes anything, it means there's a bug elsewhere that needs finding. REPOSITORY R242 Plasma Framework (Library) REVISION

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-02 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff,

D9119: Initialize scale factor to the last scale factor set on any instance

2017-12-02 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, davidedmundson, broulik. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Plasma::Svg initializes SvgPrivate::scaleFactor to 1.0. On systems with a