mwolff updated this revision to Diff 23507.
mwolff added a comment.
write unit test and document what's going on in more detail
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9189?vs=23473=23507
BRANCH
master
REVISION DETAIL
mwolff added inline comments.
INLINE COMMENTS
> mwolff wrote in kcombobox.cpp:317
> can you be more specific, such that I can build a unit test out of this? And
> are you saying that `QComboBox::setLineEdit` is deleting the line edit?
ah I think I got it now, thanks for the hint!
REPOSITORY
mwolff added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kcombobox.cpp:317
> KHistoryComboBox is constructed with line edit in, then setLineEdit removes
> it with completion object in.
can you be more specific, such that I can build a unit test out of this? And
are you saying
anthonyfieroni added a reviewer: dfaure.
anthonyfieroni added inline comments.
INLINE COMMENTS
> kcombobox.cpp:317
>
> QComboBox::setLineEdit(edit);
> d->klineEdit = qobject_cast(edit);
KHistoryComboBox is constructed with line edit in, then setLineEdit removes it
with completion
mwolff added a subscriber: dfaure.
mwolff added a comment.
This makes KMail's Open With feature work again, but I wonder - is anyone
capable of running valgrind? Or figure out where the deletion comes from?
@dfaure?
REPOSITORY
R284 KCompletion
REVISION DETAIL
mwolff edited the summary of this revision.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9189
To: mwolff
Cc: dfaure, #frameworks
mwolff created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
For some reason the 'Open With' dialog opened by KMail triggers the
following crash for me:
#0 0x68ea4220 in ?? ()
#1
