This revision was automatically updated to reflect the committed changes.
Closed by commit R284:fa2c4484d8db: Do not crash when setting new line edit on
an editable combo box (authored by mwolff).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9189?vs=23508&id=23549#toc
REPOSITORY
R284
dfaure added a comment.
@anthonyfieroni commit
https://phabricator.kde.org/R446:0c4f04b074d9d214b86721ac7c881a6ea95b8c41 seems
to have added that KLineEdit just to be able to show the clear button. This
could just be ported to QLineEdit::setClearButtonEnabled these days.
REPOSITORY
R284 K
dfaure accepted this revision.
REPOSITORY
R284 KCompletion
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9189
To: mwolff, dfaure, anthonyfieroni
Cc: #frameworks
anthonyfieroni accepted this revision.
anthonyfieroni added a comment.
This revision is now accepted and ready to land.
Let's David says but i think KOpenWithDialog should be fixed as well, why we
need new KLineEdit while KHistoryComboBox do it for us?
https://phabricator.kde.org/source/kio
mwolff edited the summary of this revision.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9189
To: mwolff, dfaure
Cc: #frameworks
mwolff updated this revision to Diff 23508.
mwolff retitled this revision from "Do not crash when completion object gets
destroyed underneath us" to "Do not crash when setting new line edit on an
editable combo box".
mwolff edited the summary of this revision.
mwolff removed subscribers: anthonyf
