This revision was automatically updated to reflect the committed changes.
Closed by commit R241:41fbb247d97c: Implement a kfile dialog where we can add
custom widget (authored by mlaurent).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9206?vs=23916=23917
mlaurent updated this revision to Diff 23916.
mlaurent added a comment.
- Remove indirection methods as requested by David. Fix doc too
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9206?vs=23908=23916
BRANCH
add_kfile_dialog
REVISION DETAIL
mlaurent marked 2 inline comments as done.
REPOSITORY
R241 KIO
BRANCH
add_kfile_dialog
REVISION DETAIL
https://phabricator.kde.org/D9206
To: mlaurent, mwolff, dfaure
Cc: #frameworks
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:41
>
> +
> )
nothing to see here
> kfilecustomdialog.cpp:65
> +
> +void KFileCustomDialogPrivate::setUrl(const QUrl )
> +{
I wonder about the
mlaurent updated this revision to Diff 23908.
mlaurent added a comment.
- Fix doc, remove unused code, etc.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9206?vs=23514=23908
BRANCH
add_kfile_dialog
REVISION DETAIL
https://phabricator.kde.org/D9206
mlaurent marked 7 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9206
To: mlaurent, mwolff, dfaure
Cc: #frameworks
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfilecustomdialogtest.h:30
> +public:
> +explicit KFileCustomDialogTest(QObject *parent = nullptr);
> +~KFileCustomDialogTest() = default;
not really
dfaure added a comment.
Hmm. I can see the usefulness, it's certainly much better than the way people
have historically inserted custom widgets into QFileDialog
(https://stackoverflow.com/questions/16987916/add-widgets-to-qfiledialog, URGH).
On the other hand, I'm wondering if this is
mlaurent added a comment.
It's the problem that if class doesn't exist nobody will think to use it (or
he will reimplement it).
After that it's not a problem for me to put this code only in LO :)
As you want :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9206
mwolff added a comment.
Most of this is just forwarding code from KFileWidget, so we could just use
that directly? I mean if our LO integration is going to be the only user of
this class, then maybe we should start by adding this code there and only
upstream it if we think more people are
mlaurent edited the test plan for this revision.
mlaurent added reviewers: mwolff, dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9206
To: mlaurent, mwolff, dfaure
Cc: #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R241 KIO
BRANCH
add_kfile_dialog
REVISION DETAIL
https://phabricator.kde.org/D9206
AFFECTED FILES
autotests/CMakeLists.txt
12 matches
Mail list logo
