hein abandoned this revision.
hein added a comment.
As mentioned, I'm OK with abandoning it. I think the change is hygienic, but
it's also a micro-optimization.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9207
To: hein, #plasma, davidedmundson, mart,
graesslin added a comment.
In https://phabricator.kde.org/D9207#201848, @hein wrote:
> Well, the maintainer spoke out against it, so not much I can do.
Please be aware that I am no longer the maintainer of kglobalaccel.
Nevertheless I recommend against it as the risk of breakage
hein added a comment.
Well, the maintainer spoke out against it, so not much I can do.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9207
To: hein, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff,
mart added a comment.
can this be resurrected?
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9207
To: hein, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff,
lesliezhai, ali-mohamed,
davidedmundson added a comment.
> The description: "I'm not as sure on this..." and "but from code skimming I
can't see anything that
I went through this code thoroughly recently for a change I made.
We know we don't have any graphical widgets used anywhere; the use of
QGuiApplication
hein removed subscribers: apol, graesslin.
hein added a reviewer: graesslin.
hein added a comment.
I consider this patch in some sense a micro-optimization. I think given our
time in the release cycle it'd be OK to apply and essentially see what if
anything breaks. However I also won't feel
graesslin added a comment.
In https://phabricator.kde.org/D9207#178257, @apol wrote:
> In https://phabricator.kde.org/D9207#176322, @graesslin wrote:
>
> > I'm against a risky change here. Especially as this becomes irrelevant
with Wayland.
>
>
> What makes it risky?
apol added a comment.
In https://phabricator.kde.org/D9207#176322, @graesslin wrote:
> I'm against a risky change here. Especially as this becomes irrelevant with
Wayland.
What makes it risky?
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9207
graesslin added a comment.
I'm against a risky change here. Especially as this becomes irrelevant with
Wayland.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9207
To: hein, #plasma, davidedmundson, mart
Cc: graesslin, plasma-devel, #frameworks, ZrenBot,
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I'm not as sure on this one as I was with https://phabricator.kde.org/D9194
and the
10 matches
Mail list logo