D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R242:78f83f5c7744: Dont set a window icon in Plasma::Dialog (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9209?vs=23520=23523

D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9209 To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot,

D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Kai Uwe Broulik
broulik added a comment. +1 I still get an icon for plasma popups in tabbox and present windows REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9209 To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot,

D9209: Don't set a window icon in Plasma::Dialog

2017-12-05 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, Frameworks, davidedmundson, graesslin. Restricted Application added projects: Plasma, Frameworks. REVISION SUMMARY Setting a window icon is costly enough to be worth avoiding when it's not actually needed. This is a resurrection