elvisangelaccio removed a dependent revision: D9242: Implemented support for
hide/show groups.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9252
To: renatoo, mwolff
Cc: #frameworks
mwolff added a comment.
thanks lgtm
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9252
To: renatoo, mwolff
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:561210cd18c9: Created GroupHiddenRole for
KPlacesModel (authored by Renato Araujo Oliveira Filho
renato.ara...@kdab.com).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9252
To: renatoo, mwolff
Cc: #frameworks
renatoo updated this revision to Diff 23647.
renatoo added a comment.
Refactored unit test
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9252?vs=23644=23647
REVISION DETAIL
https://phabricator.kde.org/D9252
AFFECTED FILES
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
you could reduce the code duplication by adding a loop. Note that you can
even write something like this:
for (auto type : {type1, type2, type3}) {
}
INLINE COMMENTS
renatoo added a dependent revision: D9242: Implemented support for hide/show
groups.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9252
To: renatoo, mwolff
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added a reviewer: mwolff.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9252
To: renatoo, mwolff
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Created new role for KPlacesModel
TEST PLAN
unit test
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9252
