mlaurent abandoned this revision.
mlaurent added a comment.
commited in kcoreaddons
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: kossebau, flherne, #frameworks
mlaurent added a comment.
ok see https://phabricator.kde.org/D9334
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: kossebau, flherne, #frameworks
dfaure added a comment.
You're right, this belongs to KF5CoreAddonsConfig.cmake
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: kossebau, flherne, #frameworks
kossebau added a comment.
In https://phabricator.kde.org/D9330#179506, @dfaure wrote:
> Why not do this in ECM?
Doing this in ECM would mean maintaining a list of macros in a repo/product
separate from the repo/products where the respective macros are defined. More,
what
kossebau added subscribers: flherne, kossebau.
kossebau added a comment.
@flherne has been working on a patch to add
list(APPEND CMAKE_AUTOMOC_MACRO_NAMES "K_PLUGIN_FACTORY_WITH_JSON")
to `KF5CoreAddonsConfig.cmake` and similar for other modules., so the needed
settings are
mlaurent added a comment.
Ok I can move it to ecm (mais in which file ?)
"kde-modules/KDECMakeSettings.cmake" ?
and it depends if apps have some specific macro for example in kmail we have
"EXPORT_KONTACT_PLUGIN" too
REPOSITORY
R241 KIO
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Why not do this in ECM?
This comment seems to come from KDE apps or something, which depend on old
ECM. But KF5.42 depends on ECM5.42, so I don't see the usefulness.
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
build
REPOSITORY
R241 KIO
BRANCH
fix_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D9330
AFFECTED FILES
CMakeLists.txt
mlaurent added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: #frameworks