mlaurent added a comment.
Arguiment from method use QString and not QLatin1String()
QString::fromLatin1 returns a QString
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added a comment.
KAboutData aboutData2(QString::fromLatin1(AppName2),
QString::fromLatin1(ProgramName2), QString::fromLatin1(Version2));
use QString::fromLatin1 is will work
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mla
velurimithun added a comment.
/home/veluri/ruqola_dep/kcoreaddons/autotests/kaboutdataapplicationdatatest.cpp:72:
error: request for member ‘setOrganizationDomain’ in ‘aboutData2’, which is of
non-class type ‘KAboutData(QLatin1String, QLatin1String, QLatin1String)’
aboutData2.setOrgan
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added a comment.
Could you paste you compile error here please.
INLINE COMMENTS
> CMakeLists.txt:1
> -remove_definitions(-DQT_NO_CAST_FROM_ASCII)
> +#remove_definitions(-DQT_NO_CAST_FROM_ASCII)
>
Better to remove it.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabri
velurimithun added a comment.
Errors in Kaboutdataappplicationdatatest file
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
velurimithun created this revision.
velurimithun added a reviewer: mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Use QStringLiteral or QLatin1String for normal strings
REPOSITORY
R244 KCoreAddons
BRANCH
master
