ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
+1, LD_LIBRARY_PATH is the Dark Side. :-)
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9550
To: apol, #frameworks, dfaure, ngraha
dfaure added a comment.
Why leave it here, commented out, without explanations?
I'd either remove it completely, or explain the '#' ...
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9550
To: apol, #frameworks, dfaure, ngraham
Cc: ngra
apol updated this revision to Diff 24473.
apol added a comment.
Explain
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9550?vs=24458&id=24473
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9550
AFFECTED FILES
kde-modules/pre
graesslin accepted this revision.
graesslin added inline comments.
INLINE COMMENTS
> prefix.sh.cmake:3-4
> +
> +# LD_LIBRARY_PATH only needed if you are building without rpath
> +# export LD_LIBRARY_PATH=@KDE_INSTALL_FULL_LIBDIR@:$LD_LIBRARY_PATH
>
Just a note: this would break for Plasma/Wayl
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:34babd2ffc86: Don't set the LD_LIBRARY_PATH in
prefix.sh (authored by apol).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9550?vs=24473&id=26159
REVI
