D9750: ExpandingWidgetModel: find the right-most column based on location

2018-01-08 Thread Milian Wolff
mwolff created this revision. mwolff added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This fixes the width calculation for the argument hint completio

D9750: ExpandingWidgetModel: find the right-most column based on location

2018-01-09 Thread Christoph Cullmann
cullmann added a comment. ;=) I assume then a KDevelop person must try it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 To: mwolff, #kate Cc: cullmann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

D9750: ExpandingWidgetModel: find the right-most column based on location

2018-01-09 Thread Kevin Funk
kfunk added a comment. LGTM, but I'll let someone else approve. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 To: mwolff, #kate Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9750: ExpandingWidgetModel: find the right-most column based on location

2018-01-09 Thread Milian Wolff
mwolff added a comment. I'll push it then REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 To: mwolff, #kate Cc: cullmann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

D9750: ExpandingWidgetModel: find the right-most column based on location

2018-01-09 Thread Milian Wolff
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:7c648c89ed11: ExpandingWidgetModel: find the right-most column based on location (authored by mwolff). REPOSITORY R39