D9766: Use at least the requested width for the argument hint tree

2018-01-18 Thread Kevin Funk
kfunk added a comment. Whoops. Sorry for accidentally reopening it to begin with. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: dhaumann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars

D9766: Use at least the requested width for the argument hint tree

2018-01-18 Thread Milian Wolff
mwolff abandoned this revision. mwolff added a comment. this was comitted already, closing it again REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: dhaumann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullm

D9766: Use at least the requested width for the argument hint tree

2018-01-16 Thread Kevin Funk
kfunk reopened this revision. kfunk added a comment. LGTM. Just a had a quick look at the appearance of the popup before vs. after the patch when doing code completion inside the a function call parameter list. Looks more consisten now, thanks! REPOSITORY R39 KTextEditor REVISION DET

D9766: Use at least the requested width for the argument hint tree

2018-01-16 Thread Milian Wolff
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:0d0284e8f8d2: Use at least the requested width for the argument hint tree (authored by mwolff). REPOSITORY R39 KTextE

D9766: Use at least the requested width for the argument hint tree

2018-01-16 Thread Dominik Haumann
dhaumann added a comment. I would prefer if you commit this soon, since then we still have 3 weeks for testing. To me this look ok, but I cannot say whether there are side-effects or not. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelo

D9766: Use at least the requested width for the argument hint tree

2018-01-16 Thread Milian Wolff
mwolff added a subscriber: kfunk. mwolff added a comment. ping? @kfunk maybe? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9766: Use at least the requested width for the argument hint tree

2018-01-09 Thread Milian Wolff
mwolff added reviewers: KDevelop, Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9766: Use at least the requested width for the argument hint tree

2018-01-09 Thread Milian Wolff
mwolff created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This ensures the code completion tree and the argument hint tree have the same width in the u