This revision was automatically updated to reflect the committed changes.
Closed by commit R242:639e8684e3b3: [Icon Item] Treat sources starting with a
slash as local file (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mart accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9812
To: broulik, #plasma, hein, mwolff, davidedmundson, mart
Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
davidedmundson accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9812
To: broulik, #plasma, hein, mwolff, davidedmundson
Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
lgtm
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9812
To: broulik, #plasma, hein, mwolff
Cc: mwolff, plasma-devel, #frameworks, ZrenBot,
broulik updated this revision to Diff 25144.
broulik added a comment.
- Incorporate suggestions by milian
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9812?vs=25141=25144
REVISION DETAIL
https://phabricator.kde.org/D9812
AFFECTED
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
lgtm in general, but can be cleaned up
INLINE COMMENTS
> iconitem.cpp:154
> +// If a file:// URL or a absolute path is passed, take the image
> pointed by that from disk
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
We have a special case for sources
