D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-14 Thread Milian Wolff
mwolff added a comment. I guess this can be abandoned now that the real culprit was found, no? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: mwolff, ngraham, mmustac, michaelh

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-11 Thread Jaime Torres Amate
jtamate added a comment. In D9840#204587 , @dfaure wrote: > Can you strace vivaldi to see what it's doing? It must be doing something wrong if it's triggering so much I/O. This is related to https://phabricator.kde.org/D10342 I've

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-11 Thread David Faure
dfaure added a comment. Can you strace vivaldi to see what it's doing? It must be doing something wrong if it's triggering so much I/O. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: ngraham, mmustac, michaelh

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-11 Thread Jaime Torres Amate
jtamate added a comment. > ! In D9840#203803 , @ngraham wrote: > Do any of the active or recently-landed patches address this? No, but I have one in https://phabricator.kde.org/D10342 REPOSITORY R309 KService REVISION DETAIL

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-09 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D9840#203563, @jtamate wrote: > Just to let you know that I know how to reproduce the high I/O of plasmashell and continuous calls to Kservice. > You can reproduce it just having opened the vivaldi web browser. (I never though

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-09 Thread Jaime Torres Amate
jtamate added a comment. Just to let you know that I know how to reproduce the high I/O of plasmashell and continuous calls to Kservice. You can reproduce it just having opened the vivaldi web browser. (I never though it could be a problem). If it goes to a webpage that still uses flash,

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-15 Thread Jaime Torres Amate
jtamate abandoned this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: ngraham, mmustac

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-15 Thread Jaime Torres Amate
jtamate added a comment. Yes, you are right, it doesn't pass the unittests with this tentative patch. Some local changes should have triggered the heavy load, because now I'm not able to reproduce them. But there is a problem somewhere (I'll investigate further) because today,

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-14 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This goes against the whole redesign of ksycoca that I did some time ago. It's supposed to check timestamps on dirs, to rebuild the cache on demand, much like many other caches

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-14 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: ngraham, mmustac

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-12 Thread Jaime Torres Amate
jtamate added a comment. In https://phabricator.kde.org/D9840#189862, @mmustac wrote: > Does this patch then also affects the speed of the copy operation? Not that I've noticed. Only the cpu in io/wait. REPOSITORY R309 KService REVISION DETAIL

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-12 Thread Marijo Mustac
mmustac added a comment. Does this patch then also affects the speed of the copy operation? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks Cc: mmustac

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-12 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY kservice uses kdirwatch to be notified when one of the directories containing it's source of information changes.