Re: KIcon API replacement (Re: patches on kcolors)

2012-03-24 Thread David Faure
On Friday 16 March 2012 00:01:50 Christoph Feck wrote: On Thursday 15 March 2012 23:29:49 Kevin Ottens wrote: On Thursday 15 March 2012 21:21:07 David Faure wrote: On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote: Client code would then look like: QIcon i = KDE::Icon(foo);

Re: KIcon API replacement (Re: patches on kcolors)

2012-03-15 Thread Kevin Ottens
On Saturday 10 March 2012 13:03:10 David Faure wrote: On Saturday 10 March 2012 11:49:21 David Faure wrote: Maybe we want to make it a method of KIconLoader/KIconEngine instead? KIconLoader::loadIcon is already taken (and returns a QPixmap), and KIconEngine is an internal class. So a new

Re: KIcon API replacement (Re: patches on kcolors)

2012-03-15 Thread David Faure
On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote: On Saturday 10 March 2012 13:03:10 David Faure wrote: On Saturday 10 March 2012 11:49:21 David Faure wrote: Maybe we want to make it a method of KIconLoader/KIconEngine instead? KIconLoader::loadIcon is already taken (and returns

Re: KIcon API replacement (Re: patches on kcolors)

2012-03-15 Thread Kevin Ottens
On Thursday 15 March 2012 21:21:07 David Faure wrote: On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote: Looks good to me. We probably want also an overload without the iconLoader parameter I guess. It default to 0, so I assume you mean for the case where someone wants to specify

Re: KIcon API replacement (Re: patches on kcolors)

2012-03-15 Thread Christoph Feck
On Thursday 15 March 2012 23:29:49 Kevin Ottens wrote: On Thursday 15 March 2012 21:21:07 David Faure wrote: On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote: Client code would then look like: QIcon i = KDE::Icon(foo); instead of: QIcon i = KDE::loadIcon(foo); (I

KIcon API replacement (Re: patches on kcolors)

2012-03-10 Thread David Faure
On Saturday 10 March 2012 11:49:21 David Faure wrote: Maybe we want to make it a method of KIconLoader/KIconEngine instead? KIconLoader::loadIcon is already taken (and returns a QPixmap), and KIconEngine is an internal class. So a new suggestion would be: namespace KDE { QIcon