Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-09-17 Thread Martin Gräßlin
Hi all, I just prepared moving kglobalacceld from plasma-workspace into kglobalaccel. You can find the code in my personal clone of kglobalaccel at [1] in branch master. The following steps were performed so far: * filter-branch on plasma-workspace to just have all kglobalacceld commits * move

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-10-03 Thread Alex Merry
On 2014-09-17 10:47, Martin Gräßlin wrote: Hi all, I just prepared moving kglobalacceld from plasma-workspace into kglobalaccel. You can find the code in my personal clone of kglobalaccel at [1] in branch master. The following steps were performed so far: * filter-branch on plasma-workspace

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-12 Thread Martin Klapetek
On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry wrote: > > On 2014-09-17 10:47, Martin Gräßlin wrote: > >> Hi all, >> >> I just prepared moving kglobalacceld from plasma-workspace into >> kglobalaccel. >> You can find the code in my personal clone of kglobalaccel at [1] in >> branch >> master. >> >> Th

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-12 Thread Aleix Pol
On Wed, Sep 17, 2014 at 11:47 AM, Martin Gräßlin wrote: > Hi all, > > I just prepared moving kglobalacceld from plasma-workspace into kglobalaccel. > You can find the code in my personal clone of kglobalaccel at [1] in branch > master. > > The following steps were performed so far: > * filter-bran

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-17 Thread šumski
On Monday 15 of December 2014 13:55:04 Martin Gräßlin wrote: > On Friday 12 December 2014 12:38:20 Martin Klapetek wrote: > > On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry wrote: > > > On 2014-09-17 10:47, Martin Gräßlin wrote: > > >> Hi all, > > >> > > >> I just prepared moving kglobalacceld from p

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-17 Thread šumski
On Wednesday 17 of December 2014 21:11:04 šumski wrote: > On Monday 15 of December 2014 13:55:04 Martin Gräßlin wrote: > > On Friday 12 December 2014 12:38:20 Martin Klapetek wrote: > > > On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry wrote: > > > > On 2014-09-17 10:47, Martin Gräßlin wrote: > > > >>

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-18 Thread Martin Klapetek
On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > > Hi, > i've checked your clone, and what new requirements will that bring, and if > the > CMakeLists there are accurate, that will create a problem. > We will have a dependency circle between kglobalaccel, kinit, kio and > kxmlgui. > Bah, I thin

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread šumski
On Thursday 18 of December 2014 20:15:52 Martin Klapetek wrote: > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > Hi, > > i've checked your clone, and what new requirements will that bring, and > > if the > > CMakeLists there are accurate, that will create a problem. > > We will have a dependen

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread Martin Klapetek
On Fri, Dec 19, 2014 at 5:46 PM, šumski wrote: > > On Thursday 18 of December 2014 20:15:52 Martin Klapetek wrote: > > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > > Hi, > > > i've checked your clone, and what new requirements will that bring, and > > > if the > > > CMakeLists there are acc

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread Albert Astals Cid
El Dijous, 18 de desembre de 2014, a les 20:15:52, Martin Klapetek va escriure: > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > Hi, > > i've checked your clone, and what new requirements will that bring, and if > > the > > CMakeLists there are accurate, that will create a problem. > > We wil

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2015-01-04 Thread David Faure
On Friday 19 December 2014 17:46:07 šumski wrote: > On Thursday 18 of December 2014 20:15:52 Martin Klapetek wrote: > > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > > Hi, > > > i've checked your clone, and what new requirements will that bring, and > > > if the > > > CMakeLists there are acc

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Gräßlin
On Friday 12 December 2014 13:04:59 Aleix Pol wrote: > On Wed, Sep 17, 2014 at 11:47 AM, Martin Gräßlin wrote: > > Hi all, > > > > I just prepared moving kglobalacceld from plasma-workspace into > > kglobalaccel. You can find the code in my personal clone of kglobalaccel > > at [1] in branch mast

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Gräßlin
On Friday 12 December 2014 12:38:20 Martin Klapetek wrote: > On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry wrote: > > On 2014-09-17 10:47, Martin Gräßlin wrote: > >> Hi all, > >> > >> I just prepared moving kglobalacceld from plasma-workspace into > >> kglobalaccel. > >> You can find the code in my

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Klapetek
On Mon, Dec 15, 2014 at 1:55 PM, Martin Gräßlin wrote: > > > Given the basically non-existing feedback on the thread (modulo Alex's > reply) > I would assume that everything is fine and we can just move the code. If > you > want to take care of it, I would certainly appreciate this. > I've relice

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-18 Thread Martin Gräßlin
On Thursday 18 December 2014 20:15:52 Martin Klapetek wrote: > On Wed, Dec 17, 2014 at 9:11 PM, šumski wrote: > > Hi, > > i've checked your clone, and what new requirements will that bring, and if > > the > > CMakeLists there are accurate, that will create a problem. > > We will have a dependency

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-19 Thread Martin Klapetek
On Fri, Dec 19, 2014 at 8:36 AM, Martin Gräßlin wrote: > > > I don't get what you want to attempt to solve the circle - remove > KActionCollection dependency from KBookmarks? > Remove KActionCollection usage from KBookmarks, that will remove the dep on KXmlGui. It's used only in one single class

Re: Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Gräßlin
On Monday 15 December 2014 19:29:03 Martin Klapetek wrote: > On Mon, Dec 15, 2014 at 1:55 PM, Martin Gräßlin wrote: > > Given the basically non-existing feedback on the thread (modulo Alex's > > reply) > > I would assume that everything is fine and we can just move the code. If > > you > > want to