Dolphin is currently broken on OSX:
---
[ 49%] Building CXX object
konqueror/src/CMakeFiles/kdeinit_konqueror.dir/konqviewmanager.cpp.o
/Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/views/dolphinview.cpp:571:25:
error: use of undeclared identifier 'KFormat'
KForm
/Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/tests/kfileitemlistviewtest.cpp:91:16:
error: no matching constructor for initialization of 'QSignalSpy'
QSignalSpy itemsRemovedSpy(m_model, &KFileItemModel::itemsRemoved);
^
CMake Error at keditbookmarks/kbookmarkmodel/CMakeLists.txt:23 (install):
install TARGETS given unknown argument "BUNDLE".
CMake Error at keditbookmarks/CMakeLists.txt:48 (install):
install TARGETS given unknown argument "BUNDLE”.
CMake Error at keditbookmarks/CMakeLists.txt:82 (install):
To make kde-baseapps build again on OSX/CI I have removed poppler from its
dependencies in config/base/kf5-qt5:
---
+# KDE/Applications
+kde/applications/kde-baseapps: -kde/kdelibs/baloo
+kde/applications/kde-baseapps: -kde/kdelibs/baloo-widgets
+kde/applications/kde-baseapps: -general/poppler
---
Hello
On Wed, Oct 8, 2014 at 12:04 PM, Marko Käning wrote:
> Dolphin is currently broken on OSX:
>
#ifdef HAVE_BALOO
#include
-#include
#endif
+#include
Can you try this?
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https:
Hi Bhushan,
On 08 Oct 2014, at 08:44 , Bhushan Shah wrote:
> #ifdef HAVE_BALOO
>#include
> -#include
> #endif
> +#include
>
> Can you try this?
that fixed some stuff, but not all:
---
[ 91%] [ 91%] Building CXX object
dolphin/src/tests/CMakeFiles/viewpropertiestest.dir/testdir.cpp.o
Bui
What about this?
#ifdef HAVE_BALOO
#include
#include
#include
#include
#include
-#include
#endif
+#include
On Wed, Oct 8, 2014 at 12:27 PM, Marko Käning wrote:
> Hi Bhushan,
>
> On 08 Oct 2014, at 08:44 , Bhushan Shah wrote:
>> #ifdef HAVE_BALOO
>>
Hi Bhushan,
thanks, it worked eventually!
Committed here:
http://commits.kde.org/kde-baseapps/e2691b93cc078366261302f92821ba0672401099
What a luck that I do not have baloo installed, otherwise this would have went
unnoticed even by Jenkins master, which does not test for a baloo-free setup. =)
On Thursday 18 December 2014 22:20:54 Marko Käning wrote:
> /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/tests/kfileitemlistvie
> wtest.cpp:91:16: error: no matching constructor for initialization of
> 'QSignalSpy' QSignalSpy itemsRemovedSpy(m_model,
> &KFileItemModel::itemsRemoved); ^
Hi Kevin,
> Note: That needs Qt 5.4 -- QSignalSpy can take a PMF only since that.
I guess that test's code should then be guarded appropriately, so that it
builds also on KDE CI's still being used Qt 5.3.2, right?
Greets,
Marko
___
Kde-frameworks-devel
On Saturday 20 December 2014 15:17:52 Marko Käning wrote:
> Hi Kevin,
>
> > Note: That needs Qt 5.4 -- QSignalSpy can take a PMF only since that.
>
> I guess that test's code should then be guarded appropriately, so that it
> builds also on KDE CI's still being used Qt 5.3.2, right?
Fixed.
--
Seems that's from Qt 5.4 "This enum was introduced or modified in Qt 5.4."
in the QUrl::UserInputResolutionOptions documentation.
On Tue, Feb 10, 2015 at 3:07 PM, Marko Käning wrote:
> To make kde-baseapps build again on OSX/CI I have removed poppler from its
> dependencies in config/base/kf5-qt
Hi Jeremy,
On 10 Feb 2015, at 23:10 , Jeremy Whiting wrote:
> Seems that's from Qt 5.4 "This enum was introduced or modified in Qt 5.4." in
> the QUrl::UserInputResolutionOptions documentation.
Shouldn’t the project then require Qt 5.4, which I’d like to see avoided for
now…
Greets,
Marko
Exactly, whoever added that code either needs to find a Qt 5.3 way to do
the same, or bump the requirement.
On Tue, Feb 10, 2015 at 3:15 PM, Marko Käning wrote:
> Hi Jeremy,
>
> On 10 Feb 2015, at 23:10 , Jeremy Whiting wrote:
>
> Seems that's from Qt 5.4 "This enum was introduced or modified i
Hi Albert,
On 10 Feb 2015, at 23:17 , Jeremy Whiting wrote:
> Exactly, whoever added that code either needs to find a Qt 5.3 way to do the
> same, or bump the requirement.
who is in charge of kde-baseapps?
I’d like to get this going on OSX with Qt 5.3.2 again, or at least see the
project set
The offending commit was from Arjun AK, I've e-mailed him and cc'ed
kde-core-devel to either bump kde-baseapps Qt requirement or
revert/workaround that use of the enumeration that is new in Qt 5.4.
On Wed, Feb 11, 2015 at 12:00 PM, Marko Käning wrote:
> Hi Albert,
>
> On 10 Feb 2015, at 23:17 ,
El Dimecres, 11 de febrer de 2015, a les 20:00:38, Marko Käning va escriure:
> Hi Albert,
>
> On 10 Feb 2015, at 23:17 , Jeremy Whiting wrote:
> > Exactly, whoever added that code either needs to find a Qt 5.3 way to do
> > the same, or bump the requirement.
> who is in charge of kde-baseapps?
>
17 matches
Mail list logo
