7/02/2015 at 14:24.
> Pushed by ogoffart into branch 'master'.
>
> Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
>
> because KIconEngine::availableSize always return something even if the icon
> is not there
>
> BUG
On Friday 21 August 2015 10:53:29 Olivier Goffart wrote:
> On Friday 21. August 2015 10:05:09 David Faure wrote:
> > Hi Olivier,
> >
> > I've been trying to fix performance problems with QIcon::fromTheme("foo")
> > when using KIconEngine, and I'm hitting a wall due to the QIcon API - more
> > prec
On Friday 21 August 2015 10:53:29 Olivier Goffart wrote:
> On Friday 21. August 2015 10:05:09 David Faure wrote:
> > Hi Olivier,
> >
> > I've been trying to fix performance problems with QIcon::fromTheme("foo")
> > when using KIconEngine, and I'm hitting a wall due to the QIcon API - more
> > prec
On Friday 21. August 2015 10:05:09 David Faure wrote:
> Hi Olivier,
>
> I've been trying to fix performance problems with QIcon::fromTheme("foo")
> when using KIconEngine, and I'm hitting a wall due to the QIcon API - more
> precisely, that fallback argument.
>
> KMail (and all similar large apps
On Sunday 23 August 2015 10:30:13 Olivier Goffart wrote:
> On Friday 21. August 2015 22:30:37 David Faure wrote:
>
>
> > > I would also approve a change to Qt to add an overload of QIcon::fromTheme
> > > with only one argument without a fallback. (this would be binary
> > > compatible, and source
On Friday 21. August 2015 22:30:37 David Faure wrote:
> > I would also approve a change to Qt to add an overload of QIcon::fromTheme
> > with only one argument without a fallback. (this would be binary
> > compatible, and source compatible unless someone took the address of
> > QIcon::fromTheme)
On Sunday 23. August 2015 12:01:38 David Faure wrote:
> On Sunday 23 August 2015 10:30:13 Olivier Goffart wrote:
> > On Friday 21. August 2015 22:30:37 David Faure wrote:
> > > > I would also approve a change to Qt to add an overload of
> > > > QIcon::fromTheme
> > > > with only one argument withou
On Monday 07 September 2015 15:53:31 Olivier Goffart wrote:
>
> But the problem is that QIcon::isNull is likely to be called anyway.
> And this will again do all the look ups in the file system.
I don't think so. That's the whole reasoning behind this change.
I added debug output in QIcon and r
On Tuesday 8. September 2015 10:26:20 David Faure wrote:
> On Monday 07 September 2015 15:53:31 Olivier Goffart wrote:
> > But the problem is that QIcon::isNull is likely to be called anyway.
> > And this will again do all the look ups in the file system.
>
> I don't think so. That's the whole rea
On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote:
> On Tuesday 8. September 2015 10:26:20 David Faure wrote:
> > On Monday 07 September 2015 15:53:31 Olivier Goffart wrote:
> > > But the problem is that QIcon::isNull is likely to be called anyway.
> > > And this will again do all the l
On Wed, Sep 9, 2015 at 5:30 PM, Volker Krause wrote:
> Olivier and me just did some profiling here, in all possible combination.
>
> The results are that both the GTK icon index and the lazy null patch bring
> significant improvements (~20% on KMail). With both of them pure Qt icon
> loading is a
On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote:
>
> I tried to optimize it by 'caching' the isNull value in QIconPrivate.
>
> But then the test failed:
> http://code.woboq.org/qt5/qtbase/tests/auto/gui/image/qicon/tst_qicon.cpp.html#633
> In that test, the "address-book-new" was lo
On Thu, September 10, 2015 09:16:11 David Faure wrote:
> On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote:
> > I tried to optimize it by 'caching' the isNull value in QIconPrivate.
> >
> > But then the test failed:
> > http://code.woboq.org/qt5/qtbase/tests/auto/gui/image/qicon/tst_qi
On Thursday 10 September 2015 19:29:23 Michael Pyne wrote:
> On Thu, September 10, 2015 09:16:11 David Faure wrote:
> > On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote:
> > > I tried to optimize it by 'caching' the isNull value in QIconPrivate.
> > >
> > > But then the test failed:
>
, David Faure and Kevin Ottens.
Repository: kiconthemes
Description
---
Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
because KIconEngine::availableSize always return something even if the icon
is not there
BUG: 342906
Diffs
-
src/kiconengine.cpp 530403e
d Feb. 17, 2015, 3:51 p.m.)
>
>
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
>
>
> Repository: kiconthemes
>
>
> Description
> ---
>
> Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
>
> because KIco
sitory: kiconthemes
>
>
> Description
> ---
>
> Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
>
> because KIconEngine::availableSize always return something even if the icon
> is not there
>
> BUG: 342906
>
>
> Diffs
> -
>
marked as submitted.
Review request for KDE Frameworks, David Faure and Kevin Ottens.
Repository: kiconthemes
Description
---
Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
because KIconEngine::availableSize always return something even if the icon
is not there
18 matches
Mail list logo
