Re: Quick Charts in KDE Review

2019-11-07 Thread Arjen Hiemstra
On 07-11-2019 15:34, Friedrich W. H. Kossebau wrote: Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic

Re: Quick Charts in KDE Review

2019-11-07 Thread Arjen Hiemstra
On 07-11-2019 15:24, Alexander Potashev wrote: чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : On 21-10-2019 15:22, Arjen Hiemstra wrote: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. > > Quick Charts is a QML module that implements a set of

Re: Quick Charts in KDE Review

2019-11-07 Thread Friedrich W. H. Kossebau
Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic name which only asks for being misunderstood, is

Re: Quick Charts in KDE Review

2019-11-07 Thread David Edmundson
Approved in general, but we will cover that and any ported applets effectively ported from KDeclarative::Plotter in relevant separate review processes. David

Re: Quick Charts in KDE Review

2019-11-07 Thread Alexander Potashev
чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : > > On 21-10-2019 15:22, Arjen Hiemstra wrote: > > Hi, > > > > Quick Charts has been moved to KDE review. The intent is to make it a > > Tier 1 framework. > > > > Quick Charts is a QML module that implements a set of > > high-performance, GPU

Re: Quick Charts in KDE Review

2019-11-07 Thread Arjen Hiemstra
On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been

Re: Quick Charts in KDE Review

2019-10-23 Thread Arjen Hiemstra
On 22-10-2019 18:09, Luigi Toscano wrote: Jonathan Riddell ha scritto: There's a file called LICENSE which contains a copy of the LGPL 2.1 But all the files with an explicit licence seem to be GPL 2+3+KDEeV Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove

Re: Quick Charts in KDE Review

2019-10-22 Thread Luigi Toscano
Jonathan Riddell ha scritto: > There's a file called LICENSE which contains a copy of the LGPL 2.1 > > But all the files with an explicit licence seem to be GPL 2+3+KDEeV > > Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove > LICENSE and put a copy of the GPL 2

Re: Quick Charts in KDE Review

2019-10-22 Thread Jonathan Riddell
There's a file called LICENSE which contains a copy of the LGPL 2.1 But all the files with an explicit licence seem to be GPL 2+3+KDEeV Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove LICENSE and put a copy of the GPL 2 called COPYING which is our normal practice.

Re: Quick Charts in KDE Review

2019-10-22 Thread Arjen Hiemstra
On 21-10-2019 16:45, Alexander Potashev wrote: Hi Arjen, 1. I don't see any checks in the autotests. Would it be easy to compare the displayed chart against a reference screenshot image, in each of the tests? The same screenshots could also help developers understand what kind of charts

Re: Quick Charts in KDE Review

2019-10-21 Thread Alexander Potashev
Hi Arjen, 1. I don't see any checks in the autotests. Would it be easy to compare the displayed chart against a reference screenshot image, in each of the tests? The same screenshots could also help developers understand what kind of charts kquickcharts is good for. 2. How to add a grid, ticks

Re: Quick Charts in KDE Review

2019-10-21 Thread Arjen Hiemstra
On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been