---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/
---
(Updated Nov. 28, 2013, 4:27 p.m.)
Status
--
This change has been mar
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review44712
---
This review has been submitted with commit
b266c82ca43d9dfff0c
> On Nov. 18, 2013, 5 p.m., Kevin Ottens wrote:
> > After discussion on the mailing list, let's get that in for the time being.
> > It is to be considered as a temporary solution and will be removed when
> > CMake 3 will be available.
>
> Kevin Ottens wrote:
> Please push it ASAP, we need
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review44453
---
Ship it!
I understood that it is important not to have to add
> On Nov. 18, 2013, 5 p.m., Kevin Ottens wrote:
> > After discussion on the mailing list, let's get that in for the time being.
> > It is to be considered as a temporary solution and will be removed when
> > CMake 3 will be available.
Please push it ASAP, we need to tie up loose ends NOW.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review43904
---
Ship it!
After discussion on the mailing list, let's get that
Kevin Ottens wrote:
> Any chance to see an update or it is abandonned?
>
Regarding what I wrote before, CMake is now (in master) able to extract the
uic options from the KF5::KI18n target. The uic executable in Qt 5.3 accepts
an -include argument
https://codereview.qt-project.org/#change,70
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename i
> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_files iirc). All I did was copy it and rename
> On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files
iirc). All I did was copy it and rename it. didn't look into making it use
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review40518
---
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review40322
---
https://git.reviewboard.kde.org/r/112795/diff/ might provide in
26 matches
Mail list logo
