Re: Review Request 122706: A KCModule base for QML based KCMs

2015-04-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/#review78707 --- This is now obsoleted? - David Edmundson On Feb. 25, 2015,

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/#review76873 --- +1 - David Edmundson On Feb. 25, 2015, 5:40 p.m., Marco

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/#review76597 --- src/CMakeLists.txt

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Marco Martin
On Feb. 25, 2015, 12:07 p.m., Marco Martin wrote: Also, would it maybe make sense to have a different library in KConfigWidgets for this? It seems quite disjoint from the rest... it's a base kcmodule, so i don't think so - Marco

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Marco Martin
On Feb. 24, 2015, 10:59 a.m., David Edmundson wrote: src/kcmoduleqml.h, line 36 https://git.reviewboard.kde.org/r/122706/diff/3/?file=351295#file351295line36 When we do make a QML only system settings we're not going to want to use KCMModule at all, even if it's not shown?

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/ --- (Updated Feb. 25, 2015, 5:40 p.m.) Review request for KDE Frameworks.

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Sebastian Kügler
On Feb. 24, 2015, 10:59 a.m., David Edmundson wrote: src/kcmoduleqml.h, line 36 https://git.reviewboard.kde.org/r/122706/diff/3/?file=351295#file351295line36 When we do make a QML only system settings we're not going to want to use KCMModule at all, even if it's not shown?

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Ben Cooksley
On Feb. 24, 2015, 10:59 a.m., David Edmundson wrote: src/kcmoduleqml.h, line 36 https://git.reviewboard.kde.org/r/122706/diff/3/?file=351295#file351295line36 When we do make a QML only system settings we're not going to want to use KCMModule at all, even if it's not shown?

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-24 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/#review76528 --- CMakeLists.txt

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/#review76526 --- CMakeLists.txt