Re: Templates for frameworks CMake files

2013-09-25 Thread Stephen Kelly
Stephen Kelly wrote: >>> Simplify by putting NO_MODULE before REQUIRED and removing COMPONENTS: >>> >>>find_package(Qt5 ${REQUIRED_QT_VERSION} NO_MODULE REQUIRED Widgets) >> >> Done. > > Are you sure? The reviewboard shows otherwise. > Ah, I was wrong here. I was looking at the KF5 line. Simpl

Re: Templates for frameworks CMake files

2013-09-25 Thread Stephen Kelly
Aurélien Gâteau wrote: >> ECM and Qt version bumps are not as much an issue as the cmake one. The >> ECM and Qt version deps are not as likely to change. > > I don't understand why you think specifying the cmake version is an issue: > it should be easy to update the template when this happens, is

Re: Templates for frameworks CMake files

2013-09-25 Thread Aurélien Gâteau
On Tuesday 24 September 2013 16:58:36 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Hi, > > > > I have been playing around with itemviews CMake files and put together > > some templates for the top level CMakeLists.txt and *Config.cmake.in. You > > can find them attached there. Any one against

Re: Templates for frameworks CMake files

2013-09-24 Thread Alexander Neundorf
On Tuesday 24 September 2013, Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Hi, > > > > I have been playing around with itemviews CMake files and put together > > some templates for the top level CMakeLists.txt and *Config.cmake.in. You > > can find them attached there. Any one against me addi

Re: Templates for frameworks CMake files

2013-09-24 Thread Stephen Kelly
Aurélien Gâteau wrote: > Hi, > > I have been playing around with itemviews CMake files and put together > some templates for the top level CMakeLists.txt and *Config.cmake.in. You > can find them attached there. Any one against me adding those to the > repository? > > Aurélien > CMakeLists.txt >

Re: Templates for frameworks CMake files

2013-09-13 Thread Aurélien Gâteau
On Friday 13 September 2013 11:30:32 Aurélien Gâteau wrote: > Hi, > > I have been playing around with itemviews CMake files and put together some > templates for the top level CMakeLists.txt and *Config.cmake.in. You can > find them attached there. Any one against me adding those to the > reposito