---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113173/#review41436
---
It makes sense to me. I would like someone else to approve.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113173/#review41458
---
Ship it!
Ship It!
- Kevin Ottens
On Oct. 8, 2013, 1:20
Aleix Pol Gonzalez wrote:
This patch adds a defined() first, before checking the value, so the
pre-processor doesn't need to consider the variable value, if it's not
present.
This seems like a bad idea.
These are defined with 1 if acceptable and undefined if the feature is
not present.
Can we keep all discussions on reviewboard?
If you mix replying to the mailing list we lose track of messages very quickly.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113173/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
Aleix Pol Gonzalez wrote:
This patch adds a defined() first, before checking the value, so the
pre-processor doesn't need to consider the variable value, if it's not
present.
This seems like a bad idea.
These are defined with 1 if acceptable and undefined if the feature is
not present.
Stephen Kelly wrote:
These are defined with 1 if acceptable and undefined if the feature is
not present.
This is the problem that should be fixed.
It should be 0 if the feature is not present. Please fix that instead.
Hmm, or maybe your fix is ok.
I don't know where the values come
On Tue, Oct 8, 2013 at 3:50 PM, Stephen Kelly steve...@gmail.com wrote:
Stephen Kelly wrote:
These are defined with 1 if acceptable and undefined if the feature is
not present.
This is the problem that should be fixed.
It should be 0 if the feature is not present. Please fix that
