Re: Remnants of monolithic kdelibs.git building

2014-04-21 Thread Nicolás Alvarez
2014-04-21 16:53 GMT-03:00 Nicolás Alvarez : > 2014-03-27 13:18 GMT-03:00 Alex Merry : >> On 27/03/14 15:39, Nicolás Alvarez wrote: >>> Many frameworks' top-level CMakeLists.txt still wrap their >>> find_package calls in: >>> >>> if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") >>>

Re: Remnants of monolithic kdelibs.git building

2014-04-21 Thread Nicolás Alvarez
2014-03-27 13:18 GMT-03:00 Alex Merry : > On 27/03/14 15:39, Nicolás Alvarez wrote: >> Many frameworks' top-level CMakeLists.txt still wrap their >> find_package calls in: >> >> if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") >> >> That's left over from when the frameworks had to

Re: Remnants of monolithic kdelibs.git building

2014-03-27 Thread Alex Merry
On 27/03/14 15:39, Nicolás Alvarez wrote: > Many frameworks' top-level CMakeLists.txt still wrap their > find_package calls in: > > if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") > > That's left over from when the frameworks had to build both standalone > and as part of the lar

Remnants of monolithic kdelibs.git building

2014-03-27 Thread Nicolás Alvarez
Many frameworks' top-level CMakeLists.txt still wrap their find_package calls in: if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}") That's left over from when the frameworks had to build both standalone and as part of the large kdelibs.git repository. Should it be removed? -- Ni