Re: Review Request 108389: Respect the HOME environment variable

2013-06-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated June 11, 2013, 11 a.m.) Status -- This change has been marke

Re: Review Request 108389: Respect the HOME environment variable

2013-06-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review34139 --- This review has been submitted with commit 07ce6442a3d30e82df7

Re: Review Request 108389: Respect the HOME environment variable

2013-05-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review32125 --- Jon any news about this patch? - Kevin Ottens On Jan. 19, 20

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Jon Severinsson
> On Jan. 19, 2013, 2:15 p.m., Oswald Buddenhagen wrote: > > fwiw, we have a similar problem in kconfig (iirc). I think that problem is the opposite. From my reading of the code it seams to use qgetenv("HOME"), falling back on QDir::homePath(), which is implemented by qgetenv("HOME"), falling

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Jon Severinsson
> On Jan. 19, 2013, 2:14 p.m., Oswald Buddenhagen wrote: > > kdecore/util/kuser_unix.cpp, line 67 > > > > > > i don't think it's actually useful to check the euid. HOME is supposed > > to match the real uid, and s

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25789 --- fwiw, we have a similar problem in kconfig (iirc). - Oswald Bu

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25788 --- kdecore/util/kuser_unix.cpp

Re: Review Request 108389: Respect the HOME environment variable

2013-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated Jan. 19, 2013, 10:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 108389: Respect the HOME environment variable

2013-01-14 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated Jan. 14, 2013, 3:59 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 108389: Respect the HOME environment variable

2013-01-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25459 --- Eek, that's 5 duplicates of the same 4 lines of code. Can't thi

Re: Review Request 108389: Respect the HOME environment variable

2013-01-13 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated Jan. 13, 2013, 6:59 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 108389: Respect the HOME environment variable

2013-01-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25386 --- Hmm, can't this code be called for other users than the current

Review Request 108389: Respect the HOME environment variable

2013-01-13 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- Review request for KDE Frameworks. Description --- This turns KUser::