Re: Review Request 109551: port KPtyProcess to QProcess

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- (Updated Sept. 23, 2013, 8:31 a.m.) Status -- This change has been di

Re: Review Request 109551: port KPtyProcess to QProcess

2013-05-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review32130 --- Martin, any news about that patch? Or we still have no clue why

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-24 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29802 --- after extensive deliberation of the code i found that ... i hav

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-19 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29432 --- kpty/tests/kptyprocesstest.h

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-19 Thread Oswald Buddenhagen
> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote: > > kpty/tests/kptyprocesstest.cpp, line 193 > > > > > > i don't think eating the sleep is a good idea. i'm sure i added it for > > a reason (in a previo

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Martin Tobias Holmedahl Sandsmark
> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote: > > kpty/tests/kptyprocesstest.cpp, line 193 > > > > > > i don't think eating the sleep is a good idea. i'm sure i added it for > > a reason (in a previo

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29478 --- kpty/tests/kptyprocesstest.cpp

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- (Updated March 18, 2013, 7:54 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29430 --- kpty/tests/kptyprocesstest.cpp

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Martin Tobias Holmedahl Sandsmark
> On March 18, 2013, 7:25 a.m., Oswald Buddenhagen wrote: > > kpty/tests/kptyprocesstest.cpp, line 180 > > > > > > why should they? you already have the solution in the previous hunk. Doh, I'm just a silly moose.

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29421 --- kpty/tests/kptyprocesstest.cpp

Review Request 109551: port KPtyProcess to QProcess

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- Review request for KDE Frameworks, kdelibs and David Faure. Description --