Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/ --- (Updated July 5, 2013, 3:35 p.m.) Status -- This change has been mark

Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/#review35638 --- This review has been submitted with commit 2bc7b4accfc6daf9ac8

Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Aleix Pol Gonzalez
> On July 5, 2013, 3:06 p.m., David Faure wrote: > > staging/kwidgets/src/utils/kcolorscheme.h, line 433 > > > > > > Remove this comment, it only applied to one of the two overloads. > > > > We are callin

Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/#review35636 --- Ship it! Well done for not listening to my suggestion :-). Ind

Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/ --- Review request for KDE Frameworks. Description --- We want to depreca