Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/ --- (Updated July 29, 2013, 2:05 p.m.) Status -- This change has been mar

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/#review36746 --- This review has been submitted with commit aa16577f402549c7372

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/#review36349 --- Ship it! Ship It! - Kevin Ottens On July 8, 2013, 4:09 p.m.

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-21 Thread Kevin Ottens
> On July 10, 2013, 9 a.m., Kevin Ottens wrote: > > Only style nitpicks I didn't spot the last time. Since it can't get in yet > > anyway we've time. ;-) > > Aleix Pol Gonzalez wrote: > It can go in now, no? can I get a ship it? :D Looks like it can go in now, QFontsDatabase::systemFont re

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-19 Thread Aleix Pol Gonzalez
> On July 10, 2013, 9 a.m., Kevin Ottens wrote: > > Only style nitpicks I didn't spot the last time. Since it can't get in yet > > anyway we've time. ;-) It can go in now, no? can I get a ship it? :D - Aleix --- This is an automaticall

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/#review35826 --- Only style nitpicks I didn't spot the last time. Since it can't

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-10 Thread Kevin Ottens
> On July 8, 2013, 11:19 a.m., Kevin Ottens wrote: > > khtml/khtml_settings.cpp, line 30 > > > > > > Huh? Shouldn't be needed anymore. > > Aleix Pol Gonzalez wrote: > It's needed for KDE_DEFAULT_CHANGECURSOR.

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/ --- (Updated July 8, 2013, 4:09 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-08 Thread Aleix Pol Gonzalez
> On July 8, 2013, 11:19 a.m., Kevin Ottens wrote: > > khtml/khtml_settings.cpp, line 30 > > > > > > Huh? Shouldn't be needed anymore. It's needed for KDE_DEFAULT_CHANGECURSOR. > On July 8, 2013, 11:19 a.m., Kev

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-08 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/#review35724 --- kdeui/util/kglobalsettings.cpp

Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/ --- Review request for KDE Frameworks. Description --- Finally my patch i