---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review37187
---
staging/kservice/src/desktoptojson/kconfigtojson.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review37244
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 7, 2013, 1:28 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 5, 2013, 11:29 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review37175
---
staging/kservice/src/desktoptojson/kconfigtojson.h
On Aug. 3, 2013, 10:20 p.m., Milian Wolff wrote:
staging/kservice/src/desktoptojson/kconfigtojson.h, line 37
http://git.reviewboard.kde.org/r/111689/diff/9/?file=176099#file176099line37
why members? that's imo a verschlimmbesserung. If at all, mark them
as static const.
const:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 4, 2013, 3:58 a.m.)
Review request for KDE Frameworks and
On Aug. 2, 2013, 9:08 a.m., David Faure wrote:
staging/kservice/tools/desktoptojson/kconfigtojson.h, line 31
http://git.reviewboard.kde.org/r/111689/diff/8/?file=175878#file175878line31
I don't like file-static QStrings (global objects), and even less in
headers (it creates an
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 3, 2013, 10:07 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review37039
---
staging/kservice/src/desktoptojson/kconfigtojson.h
On Aug. 2, 2013, 9:08 a.m., David Faure wrote:
staging/kservice/tools/desktoptojson/kconfigtojson.h, line 31
http://git.reviewboard.kde.org/r/111689/diff/8/?file=175878#file175878line31
I don't like file-static QStrings (global objects), and even less in
headers (it creates an
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36959
---
staging/kservice/tools/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36960
---
staging/kservice/tools/desktoptojson/kconfigtojson.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36906
---
Some more nitpicks from my side - sorry Sebas I hope you don't
On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote:
Some more nitpicks from my side - sorry Sebas I hope you don't think I'm
too pedantic :) But I hope others read this as well and start following the
new best-practices for Qt5 codebases.
No problem at all, in fact I much appreciate the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 1, 2013, 4:32 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36923
---
staging/kservice/tools/desktoptojson/kconfigtojson.h
On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote:
staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57
http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57
Do we want the output/errors to be translated?
It's really a helper tool for the build
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 1, 2013, 5:44 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 1, 2013, 5:49 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 1, 2013, 6:03 p.m.)
Review request for KDE Frameworks and
On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote:
staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57
http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57
Do we want the output/errors to be translated?
Sebastian Kügler wrote:
It's really a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36933
---
nearly there! :)
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote:
staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60
http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60
just do return convert(...);
No, that would give the opposite return value. To have the same
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 1, 2013, 6:56 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated Aug. 1, 2013, 6:59 p.m.)
Review request for KDE Frameworks and
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote:
staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60
http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60
just do return convert(...);
Nicolás Alvarez wrote:
No, that would give the opposite
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36947
---
Ship it!
awesome, I like it now :)
- Milian Wolff
On Aug.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
---
(Updated July 30, 2013, 7:45 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36841
---
staging/kservice/tools/desktoptojson/kconfigtojson.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36501
---
staging/kservice/tools/desktoptojson/kconfigtojson.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36503
---
staging/kservice/tools/desktoptojson/kconfigtojson.h
32 matches
Mail list logo
