---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---
(Updated Sept. 9, 2013, 4:13 a.m.)
Status
--
This change has been
On Sept. 4, 2013, 9:26 a.m., Martin Gräßlin wrote:
Here's a diff fixing the issues:
diff --git a/find-modules/FindXCB.cmake b/find-modules/FindXCB.cmake
index 2684ed0..823d167 100644
--- a/find-modules/FindXCB.cmake
+++ b/find-modules/FindXCB.cmake
@@ -60,9 +60,15 @@
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/#review39317
---
Ship it!
Ship It!
- Stephen Kelly
On Sept. 4, 2013, 7:45
On Aug. 27, 2013, 6:08 p.m., Stephen Kelly wrote:
find-modules/FindXCB.cmake, line 184
http://git.reviewboard.kde.org/r/112151/diff/1/?file=183395#file183395line184
I don't think 'NAMES lib' is correct. That will search for a lib named
'lib' with certain patterns, eg liblib.so.
On Aug. 27, 2013, 4:08 p.m., Stephen Kelly wrote:
find-modules/FindXCB.cmake, line 184
http://git.reviewboard.kde.org/r/112151/diff/1/?file=183395#file183395line184
I don't think 'NAMES lib' is correct. That will search for a lib named
'lib' with certain patterns, eg liblib.so.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---
(Updated Sept. 3, 2013, 9:37 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/#review39235
---
Thanks.
Copying what I wrote before:
You wrote that it
On Sept. 3, 2013, 8:07 a.m., Stephen Kelly wrote:
Thanks.
Copying what I wrote before:
You wrote that it allows having some components be optional, and others
be required. However, you don't seem to follow the advice here to do
that:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/#review39244
---
find-modules/FindXCB.cmake
On Sept. 3, 2013, 11:40 a.m., Stephen Kelly wrote:
find-modules/FindXCB.cmake, line 187
http://git.reviewboard.kde.org/r/112151/diff/2/?file=186650#file186650line187
Is it even possible to hit these fatal errors? I thought find_path and
find_library would always set the variable
On Sept. 3, 2013, 9:40 a.m., Stephen Kelly wrote:
find-modules/FindXCB.cmake, line 187
http://git.reviewboard.kde.org/r/112151/diff/2/?file=186650#file186650line187
Is it even possible to hit these fatal errors? I thought find_path and
find_library would always set the variable
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---
(Updated Sept. 4, 2013, 6:57 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---
Review request for KDE Frameworks and Alexander Neundorf.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
---
(Updated Aug. 19, 2013, 9:39 a.m.)
Review request for KDE Frameworks,
14 matches
Mail list logo
