---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review44712
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review44453
---
Ship it!
I understood that it is important not to have to add
Kevin Ottens wrote:
Any chance to see an update or it is abandonned?
Regarding what I wrote before, CMake is now (in master) able to extract the
uic options from the KF5::KI18n target. The uic executable in Qt 5.3 accepts
an -include argument
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files
iirc). All I did was copy it and rename it. didn't look into making it use
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review40322
---
https://git.reviewboard.kde.org/r/112795/diff/ might provide
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/
---
Review request for KDE Frameworks and Alexander Neundorf.
Description
19 matches
Mail list logo
