Re: Review Request 112928: Template files for frameworks

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review41181 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 27, 2013,

Re: Review Request 112928: Template files for frameworks

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review41182 --- This review has been submitted with commit

Re: Review Request 112928: Template files for frameworks

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Oct. 3, 2013, 2:31 p.m.) Status -- This change has been

Re: Review Request 112928: Template files for frameworks

2013-09-27 Thread Aurélien Gâteau
On Sept. 26, 2013, 10:27 p.m., Alexander Neundorf wrote: template/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/112928/diff/5/?file=192796#file192796line22 The idea here was that you can simply list all required KF5 frameworks in one find_package() call:

Re: Review Request 112928: Template files for frameworks

2013-09-27 Thread Stephen Kelly
On Sept. 26, 2013, 8:27 p.m., Alexander Neundorf wrote: template/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/112928/diff/5/?file=192796#file192796line22 The idea here was that you can simply list all required KF5 frameworks in one find_package() call:

Re: Review Request 112928: Template files for frameworks

2013-09-27 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 27, 2013, 5:05 p.m.) Review request for KDE Frameworks,

Re: Review Request 112928: Template files for frameworks

2013-09-27 Thread Aurélien Gâteau
On Sept. 26, 2013, 10:27 p.m., Alexander Neundorf wrote: template/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/112928/diff/5/?file=192796#file192796line22 The idea here was that you can simply list all required KF5 frameworks in one find_package() call:

Re: Review Request 112928: Template files for frameworks

2013-09-27 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40917 --- This looks complete to me. - Stephen Kelly On Sept. 27,

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 1:28 p.m.) Review request for KDE Frameworks,

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40855 --- template/CMakeLists.txt

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 2:05 p.m.) Review request for KDE Frameworks,

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Aurélien Gâteau
On Sept. 26, 2013, 1:55 p.m., Stephen Kelly wrote: template/CMakeLists.txt, line 16 http://git.reviewboard.kde.org/r/112928/diff/2/?file=192771#file192771line16 Can this be changed from REQUIRED MODULE COMPONENTS to MODULE REQUIRED

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40861 --- template/CMakeLists.txt

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 3:13 p.m.) Review request for KDE Frameworks,

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40866 --- Maybe KF5_SELF_VERSION could be shortened to KF5_VERSION?

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 4:36 p.m.) Review request for KDE Frameworks,

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 4:37 p.m.) Review request for KDE Frameworks,

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Aurélien Gâteau
On Sept. 26, 2013, 3:43 p.m., Stephen Kelly wrote: Maybe KF5_SELF_VERSION could be shortened to KF5_VERSION? Yes, that might be better. The patch looks good to me now. The above naming issue and the other re-ordering issue are up to your preferences. This also marks a

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40893 --- template/CMakeLists.txt

Re: Review Request 112928: Template files for frameworks

2013-09-26 Thread Stephen Kelly
On Sept. 26, 2013, 8:27 p.m., Alexander Neundorf wrote: template/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/112928/diff/5/?file=192796#file192796line22 The idea here was that you can simply list all required KF5 frameworks in one find_package() call:

Review Request 112928: Template files for frameworks

2013-09-25 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.

Re: Review Request 112928: Template files for frameworks

2013-09-25 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40802 --- Also consider replacing FooBar with @FooBar@ or something that