Review Request 112932: Update superbuild to include all tiered libraries

2013-09-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/ --- Review request for KDE Frameworks. Description --- Add missing find_

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-10-09 Thread Kevin Ottens
> On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me, not adding the shipit because I'm clueless about > > superbuild. > > > > Why do we need to specify the dependencies from superbuild? Shouldn't they > > depend on the Config.cmake files? > > Alexander Neundorf wrot

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-10-09 Thread Alexander Neundorf
On Wednesday 09 October 2013, Kevin Ottens wrote: > > On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote: > > > Looks good to me, not adding the shipit because I'm clueless about > > > superbuild. > > > > > > Why do we need to specify the dependencies from superbuild? Shouldn't > > > they depe

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-10-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/ --- (Updated Oct. 9, 2013, 5:22 p.m.) Status -- This change has been disc

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-10-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/#review41457 --- It seems no-one uses superbuild, so I'm discarding it. - David

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-09-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/#review40764 --- Looks good to me, not adding the shipit because I'm clueless ab

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-09-25 Thread Alexander Neundorf
> On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me, not adding the shipit because I'm clueless about > > superbuild. > > > > Why do we need to specify the dependencies from superbuild? Shouldn't they > > depend on the Config.cmake files? You mean after "DEPENDS" ?

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-09-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/#review40789 --- Is anyone really using superbuild? - Albert Astals Cid On S