Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review42188 --- This review has been submitted with commit b2e2218bc7677ac8f34

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-22 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 22, 2013, 10:09 p.m.) Status -- This change has been ma

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-21 Thread Kevin Ottens
> On Oct. 11, 2013, 4:28 p.m., Kevin Ottens wrote: > > Ship It! Any reason why this patch is not pushed yet? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review41567 --

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-11 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review41567 --- Ship it! Ship It! - Kevin Ottens On Oct. 6, 2013, 9:02 p.m.

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-09 Thread David Gil Oliva
> On Oct. 9, 2013, 5:05 p.m., Kevin Ottens wrote: > > I'm not sure what this patch is trying to achieve. It doesn't look much > > more clearer API to me than what we had before. :-) > > > > Could you share a bit more of the rationale? I guess I'm missing something. Ok, let's see. We have a met

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-09 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review41450 --- I'm not sure what this patch is trying to achieve. It doesn't l

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 6, 2013, 9:02 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-02 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 2, 2013, 9:33 p.m.) Review request for KDE Frameworks. Cha

Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-09-28 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- Review request for KDE Frameworks. Description --- Adjust API in KEmo