Review Request 113077: Get Kross ready for tier3

2013-10-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113077: Get Kross ready for tier3

2013-10-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/#review41350 --- You broke the build (and forgot to include the REVIEW tag ;-):

Re: Review Request 113077: Get Kross ready for tier3

2013-10-07 Thread Martin Gräßlin
> On Oct. 7, 2013, 4:38 p.m., Martin Gräßlin wrote: > > You broke the build (and forgot to include the REVIEW tag ;-): > > [ 41%] Building CXX object > > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o > > In file included from > > /home/martin/kf5/src/kdelibs-frameworks/kross/src/cor

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Vishesh Handa
> On Oct. 7, 2013, 2:38 p.m., Martin Gräßlin wrote: > > You broke the build (and forgot to include the REVIEW tag ;-): > > [ 41%] Building CXX object > > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o > > In file included from > > /home/martin/kf5/src/kdelibs-frameworks/kross/src/cor

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/ --- (Updated Oct. 8, 2013, 7:47 a.m.) Status -- This change has been mark

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Kevin Ottens
> On Oct. 7, 2013, 2:38 p.m., Martin Gräßlin wrote: > > You broke the build (and forgot to include the REVIEW tag ;-): > > [ 41%] Building CXX object > > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o > > In file included from > > /home/martin/kf5/src/kdelibs-frameworks/kross/src/cor

Re: Review Request 113077: Get Kross ready for tier3

2013-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/#review41189 --- Ship it! Looks sensible kross/core/CMakeLists.txt