Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- Review request for KDE Frameworks and kdelibs. Repository: kdelibs Descr

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 12:51 a.m.) Review request for KDE Frameworks and

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41860 --- There are couple issues still, I pointed only bunch of them as

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4 p.m.) Review request for KDE Frameworks and kdel

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
> On Oct. 17, 2013, 4:46 a.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 183 > > > > > > Spaces inside -> "KDirWatch *, bool" I added the parameter names to kdirwatch_p.h too.

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4:05 p.m.) Review request for KDE Frameworks and k

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41907 --- Good job! I think this can go in, but I'd like someone else app

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
> On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp, line 1225 > > > > > > I think this could be better as uncommenting the variable and using > > Q_UNUSED (and m

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4:53 p.m.) Review request for KDE Frameworks and k

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
> On Oct. 17, 2013, 7:27 p.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 199 > > > > > > why did you choose "_path" instead of just "path"? > > Nicolás Alvarez wrote: > Becau

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review42078 --- Ship it! Ship It! - Kevin Ottens On Oct. 17, 2013, 7:53 p.m

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-21 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 21, 2013, 10:30 p.m.) Status -- This change has been ma

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review42138 --- This review has been submitted with commit 11ee78a9c8139f236f3