Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/#review41895 --- This review has been submitted with commit 7b4c83df7f09e3585cf

Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/ --- (Updated Oct. 17, 2013, 3:04 p.m.) Status -- This change has been mar

Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/#review41873 --- Ship it! Looks good to me. It's strange to have exported funct

Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/#review41858 --- I find this a better solution. So if I compare my review with t

Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kdelibs