Re: Review Request 113395: Enable KConfig on Windows

2013-10-29 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 29, 2013, 12:58 p.m.) Status -- This change has been ma

Re: Review Request 113395: Enable KConfig on Windows

2013-10-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42630 --- This review has been submitted with commit e91aa4ba3e6e5f3ca93

Re: Review Request 113395: Enable KConfig on Windows

2013-10-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42583 --- Ship it! Looks good to me too. The owner id issue can be fixed

Re: Review Request 113395: Enable KConfig on Windows

2013-10-25 Thread Andrius da Costa Ribas
> On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: > > tier1/kconfig/src/core/kconfigini.cpp, line 425 > > > > > > Files have no owner on Windows. QFileInfo::ownerId() always returns -2 > > on Windows a

Re: Review Request 113395: Enable KConfig on Windows

2013-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42335 --- Looks good to me (don't know about the ownerId() stuff. Maybe Q

Re: Review Request 113395: Enable KConfig on Windows

2013-10-23 Thread Alexander Richardson
> On Oct. 23, 2013, 3:25 a.m., Andrius da Costa Ribas wrote: > > tier1/kconfig/src/core/kconfigini.cpp, line 425 > > > > > > Files have no owner on Windows. QFileInfo::ownerId() always returns -2 > > on Windows a

Re: Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Andrius da Costa Ribas
> On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: > > tier1/kconfig/src/core/kconfigini.cpp, line 425 > > > > > > Files have no owner on Windows. QFileInfo::ownerId() always returns -2 > > on Windows a

Re: Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42192 --- tier1/kconfig/src/core/kconfigini.cpp

Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- Review request for KDE Frameworks. Repository: kdelibs Description -