Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/#review42555 --- This review has been submitted with commit 9a1390c2b53415b7bef

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/ --- (Updated Oct. 28, 2013, 8:32 p.m.) Status -- This change has been mar

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-24 Thread Alex Merry
> On Oct. 24, 2013, 7:25 p.m., Alex Merry wrote: > > whoami is part of coreutils, so should be available everywhere. The only > > possible issue I see is that we've gone from a test that doesn't depend on > > PATH to one that does. This isn't necessarily a problem, but it will test > > sligh

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-24 Thread Nicolás Alvarez
> On Oct. 24, 2013, 4:25 p.m., Alex Merry wrote: > > whoami is part of coreutils, so should be available everywhere. The only > > possible issue I see is that we've gone from a test that doesn't depend on > > PATH to one that does. This isn't necessarily a problem, but it will test > > sligh

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/#review42320 --- Ship it! whoami is part of coreutils, so should be available e

Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/ --- Review request for KDE Frameworks. Repository: kdelibs Description -