Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-25 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- Review request for KDE Frameworks, Sebastian Kügler and Stephen Kelly. Rep

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-25 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/#review42361 --- Why does that library not install a Config.cmake file? - Steph

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-25 Thread Aurélien Gâteau
> On Oct. 25, 2013, 5:40 p.m., Stephen Kelly wrote: > > Why does that library not install a Config.cmake file? Sebas put together a patch to do so, but it needs to be refined because it currently does not work for Qt4 (dbusmenu-qt is Qt4 and Qt5). Furthermore, the upstream project needs to acc

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- (Updated Oct. 30, 2013, 3:15 p.m.) Status -- This change has been dis

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-30 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/#review42706 --- I still don't understand why a Config file is not added upstrea

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-30 Thread Stephen Kelly
> On Oct. 30, 2013, 2:21 p.m., Stephen Kelly wrote: > > I still don't understand why a Config file is not added upstream, so I'll > > not 'shipit'. Oops, I thought this was updated, not discarded. - Stephen --- This is an automatically