---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/#review46448
---
This looks wrong to me. This code was in KFileWidget in kde4
On Dec. 30, 2013, 2:23 p.m., David Faure wrote:
This looks wrong to me. This code was in KFileWidget in kde4 already. OTOH
the port of KEncodingFileDialog to KFileWidget is what's new in frameworks.
So I'd be quite tempted to say that the bug is in the way
KEncodingFileDialog uses
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/
---
(Updated Dec. 30, 2013, 9 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/#review46461
---
Ah I see, the issue is when calling setLocationText() with a
On Dec. 30, 2013, 9:54 p.m., David Faure wrote:
Ah I see, the issue is when calling setLocationText() with a relative URL.
The KDE4 code (inside setLocationText) would say
if (url.hasPath()) {
if (!url.directory().isEmpty()) {
q-setUrl(...);
} else {
On Dec. 30, 2013, 9:54 p.m., David Faure wrote:
Ah I see, the issue is when calling setLocationText() with a relative URL.
The KDE4 code (inside setLocationText) would say
if (url.hasPath()) {
if (!url.directory().isEmpty()) {
q-setUrl(...);
} else {
On Dec. 30, 2013, 9:54 p.m., David Faure wrote:
Ah I see, the issue is when calling setLocationText() with a relative URL.
The KDE4 code (inside setLocationText) would say
if (url.hasPath()) {
if (!url.directory().isEmpty()) {
q-setUrl(...);
} else {
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/
---
(Updated Dec. 31, 2013, 6:24 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/
---
Review request for KDE Frameworks.
Repository: kio
Description
---